Testing improvements #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const fileChooserPromise = page.waitForEvent('filechooser') | ||
| await page.getByText('Upload data').click() | ||
| const fileChooser = await fileChooserPromise | ||
| await fileChooser.setFiles('test/testData/conservation-area-errors.csv') |
There was a problem hiding this comment.
If I were being really nitpicky it might be helpful if you could name the file with which errors were in it for other people looking at it later, e.g 'conservation-area-missing-reference(-error?).csv'
There was a problem hiding this comment.
there's only one file with errors that i have. and it has missing ref and invalid values
CarlosCoelhoSL
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://trello.com/c/26DCaM71/1161-add-some-additional-tests-to-the-frontend
Just a ticket that adds some more testing